⚠️ No Changeset found

Latest commit: de55193

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rkistner based on this https://discord.com/channels/1138230179878154300/1291056749197131796 the general issue is an unsecure context being used (e.g. http://192.168...) which results in a hard to diagnose issue for users. The idea with this is to warn users when navigator locks are not available and to then have a fallback so they can still continue albeit with more limited functionality.

Ok, I wasn't aware of the secure context limitation.

Is it feasible to limit this to only "safe" setups, such as when using a SharedWorker? I'm concerned that silent data corruption because of a lack of cross-tab locks could be even more difficult to debug.

I did some digging and found that WA-SQLite also uses the navigator.locks API internally. From what I could see Navigator locks are currently unavoidable if we use the IDBBatchAtomicVFS VFS which uses WebLocks under the hood.

HI there, is this work complete? And if so do you have any idea when it will be released? I think I am in a situation where this would benefit me, I am building a nextjs application and then converting it to ios and android app using capacitor. Powersync seems to work well when the apps are bundled fully, but during the development process I am pointing to local host and using the nextjs instance that is running there, which enables hot reloading of my changes in xcode and android studio, this method doesn't work with powersync, I get an error that mentions navigator locks.

Apologies if this is unrelated, but would be a massive help if your changes solve it! happy to test them on this use case if you can point me in the direction of a package with the changes implemented.

This is released already, but it only checks that navigator.locks are present, giving a better error message when it isn't.

Even if we removed usage of the locks here, wa-sqlite still uses the same navigator.locks internally, so it is something that is required.

You say you're pointing to local host in development - is that http://localhost:<port>, or for example using your WiFi IP? localhost should work as far as I know, but the WiFi IP won't. At least for Android you can use adb reverse to expose your development server as an actual http://localhost URL on the device. Not sure if there is an equivalent for iOS.

@rkistner Thanks very much for the response, I will give that a try